Skip to content

Fix #8069: Disallow parameter dependent case classes #8074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

Fix #8069: Disallow parameter dependent case classes #8074

merged 1 commit into from
Jan 23, 2020

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jan 22, 2020

This avoids the crash but intorduces an implementation restriction. I have opened
#8073, which suggests a full implementation of parameter dependent case classes
so that the restriction can be dropped.

@odersky
Fix scala#8069: Disallow parameter dependent case classes
27f4f2c 
This avoids the crash but intorduces an implementation restriction. I have opened
scala#8073, which suggests a full implementation of parameter dependent case classes
so that the restriction can be dropped.
@odersky odersky requested a review from liufengyun January 23, 2020 07:29
liufengyun
liufengyun approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 19b51b9 into scala:master Jan 23, 2020
@liufengyun liufengyun deleted the fix-#8069 branch January 23, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @liufengyun